Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4397#discussion_r129375055
--- Diff:
flink-core/src/main/java/org/apache/flink/core/fs/ConsistencyLevel.java ---
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.core.fs;
+
+/**
+ * An enumeration describing the level of consistency offered by a {@link
FileSystem}.
+ *
+ * <p>The consistency levels described here make statements about the
visibility
+ * of file existence and file contents in the presence of <i>new file
creation</i>,
+ * <i>file deletion</i>, <i>file renaming</i>, and <i>directory
listing</i>.
+ *
+ * <p>An operation is defined as consistent if the following holds: After
the function
+ * call triggering the operation returns, its result is immediately
reflected in
+ * in the view presented to any other party calling a file system function.
+ *
+ * <p>Please note that these levels do not make any statements about the
effects or visibility of
+ * file content modification or file appends. In fact, content
modification or appending are
+ * not supported in various file systems.
+ *
+ * <p>Some of these consistency levels indicate that the storage system
does not actually
+ * qualify to be called a FileSystem, but rather a blob-/object store.
+ */
+public enum ConsistencyLevel {
--- End diff --
Not sure if we actually need this enum. The summary in the javadoc contain
a list of filesystem properties that are relevant to us; could we not
explicitly define these in the `FileSystemKind` intead of indirectly going
through the ConsistencyLevel? I.e. change the constructor of `FileSystemKind`
from taking a consistency level to taking separate arguments for each property.
(Let's say `ConsistencyProperties`)
I'm worried that the list will keep growing over time, and looking at the
`FileSystemKind` enum it looks like we duplicate things; we have a posix
FileSystemKind with a posix ConsistencyLevel and so on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
