[ 
https://issues.apache.org/jira/browse/FLINK-7281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103120#comment-16103120
 ] 

ASF GitHub Bot commented on FLINK-7281:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4407#discussion_r129824759
  
    --- Diff: tools/force-shading/pom.xml ---
    @@ -93,11 +93,13 @@ under the License.
                                <plugin>
                                        
<groupId>org.apache.maven.plugins</groupId>
                                        
<artifactId>maven-release-plugin</artifactId>
    -                                   <version>2.1</version>
    +                                   <version>2.5.3</version>
                                        <configuration>
    -                                           
<mavenExecutorId>forked-path</mavenExecutorId>
    -                                           
<useReleaseProfile>false</useReleaseProfile>
    -                                           <arguments>${arguments} 
-Psonatype-oss-release</arguments>
    +                                           
<releaseProfiles>release</releaseProfiles>
    +                                           <preparationGoals>clean 
install</preparationGoals>
    +                                           <goals>deploy</goals>
    +                                           
<autoVersionSubmodules>true</autoVersionSubmodules>
    +                                           <pushChanges>false</pushChanges>
    --- End diff --
    
    `autoVersionSubmodules` tells it to update the version in all the 
submodules. `pushChanges` instructs it to not early push new branches, commits, 
tags to git. Otherwise it does that, which seems a bit crazy.


> Fix various issues in (Maven) release infrastructure
> ----------------------------------------------------
>
>                 Key: FLINK-7281
>                 URL: https://issues.apache.org/jira/browse/FLINK-7281
>             Project: Flink
>          Issue Type: Bug
>          Components: Build System
>    Affects Versions: 1.3.1, 1.4.0
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Blocker
>             Fix For: 1.4.0, 1.3.2
>
>
> I discovered couple of issues while getting ready for release 1.3.2:
> * some old, misleading release scripts and release README
> * the _maven-release-plugin_ is not correctly configured for doing actual 
> releases with it
> * the quickstarts are not configured to depend on the project version and 
> thus require manual updating, also of slf4j and log4j versions
> * the _maven-javadoc-plugin_ configuration does not work when using the the 
> _maven-release-plugin_, that is we have to move the config to the plugin 
> section and out of the _release_ profile



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to