[ 
https://issues.apache.org/jira/browse/FLINK-6521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16104728#comment-16104728
 ] 

ASF GitHub Bot commented on FLINK-6521:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4376#discussion_r130052278
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/zookeeper/HighAvailabilityServiceTest.java
 ---
    @@ -0,0 +1,115 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.highavailability.zookeeper;
    +
    +import akka.actor.ActorRef;
    +import org.apache.curator.test.TestingServer;
    +import org.apache.flink.api.common.JobID;
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.configuration.HighAvailabilityOptions;
    +import org.apache.flink.core.fs.FileSystem;
    +import org.apache.flink.runtime.akka.ListeningBehaviour;
    +import org.apache.flink.runtime.blob.FileSystemBlobStore;
    +import org.apache.flink.runtime.concurrent.Executors;
    +import org.apache.flink.runtime.highavailability.HighAvailabilityServices;
    +import org.apache.flink.runtime.jobgraph.JobGraph;
    +import org.apache.flink.runtime.jobmanager.JobInfo;
    +import org.apache.flink.runtime.jobmanager.SubmittedJobGraph;
    +import org.apache.flink.runtime.jobmanager.SubmittedJobGraphStore;
    +import org.apache.flink.runtime.util.ZooKeeperUtils;
    +
    +import org.junit.After;
    +import org.junit.Before;
    +import org.junit.Rule;
    +import org.junit.Test;
    +
    +import org.junit.Assert;
    +import org.junit.rules.ExpectedException;
    +
    +public class HighAvailabilityServiceTest {
    --- End diff --
    
    If we let the test case extend from `TestLogger`, then we get nice testing 
log statement on Travis.


> Add per job cleanup methods to HighAvailabilityServices
> -------------------------------------------------------
>
>                 Key: FLINK-6521
>                 URL: https://issues.apache.org/jira/browse/FLINK-6521
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.3.0, 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Fang Yong
>
> The {{HighAvailabilityServices}} are used to manage services and persistent 
> state at a single point. This also entails the cleanup of data used for HA. 
> So far the {{HighAvailabilityServices}} can only clean up the data for all 
> stored jobs. In order to support cluster sessions, we have to extend this 
> functionality to selectively delete data for single jobs. This is necessary 
> to keep data for failed jobs and delete data for successfully executed jobs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to