Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4413#discussion_r130072157
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
 ---
    @@ -1044,10 +1050,23 @@ public boolean restoreLatestCheckpointedState(
                                throw new 
IllegalStateException("CheckpointCoordinator is shut down");
                        }
     
    -                   // Recover the checkpoints
    -                   completedCheckpointStore.recover(sharedStateRegistry);
    +                   // We create a new shared state registry object, so 
that all pending async disposal requests from previous
    +                   // runs will go against the old object (were they can 
do nor harm). The old registry is first closed, so
    --- End diff --
    
    nit: `no harm` instead of `nor harm`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to