[
https://issues.apache.org/jira/browse/FLINK-7269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107064#comment-16107064
]
ASF GitHub Bot commented on FLINK-7269:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4415#discussion_r130312761
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/Configuration.java ---
@@ -79,7 +79,15 @@ public Configuration(Configuration other) {
}
//
--------------------------------------------------------------------------------------------
-
+
+ /**
+ * Set the process-wide dynamic properties to be merged with the
configuration.
+ * @param dynamicProperties The given dynamic properties
+ */
+ public void setDynamicProperties(Configuration dynamicProperties) {
+ this.addAll(dynamicProperties);
+ }
--- End diff --
Why not using directly `addAll`?
> Refactor passing of dynamic properties
> --------------------------------------
>
> Key: FLINK-7269
> URL: https://issues.apache.org/jira/browse/FLINK-7269
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 1.3.1
> Reporter: Till Rohrmann
> Assignee: Fang Yong
>
> In order to set dynamic properties when loading the {{Configuration}} via
> {{GlobalConfiguration.loadConfiguration}}, we currently set a static field in
> {{GlobalConfiguration}} which is read whenever we load the {{Configuration}}.
> I think this is not a good pattern I propose to remove this functionality.
> Instead we should explicitly add the dynamic properties to the loaded
> {{Configuration}} at start of the application.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
