[
https://issues.apache.org/jira/browse/FLINK-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107079#comment-16107079
]
ASF GitHub Bot commented on FLINK-7166:
---------------------------------------
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4309
Thanks for the fix. I think this LGTM, +1.
@NicoK could you rebase on the latest master to incorproate the new test
profiles (just to make sure nothing bad is affected by this change, although I
don't really expect it)?
After a green run I'll merge this!
> generated avro sources not cleaned up or re-created after changes
> -----------------------------------------------------------------
>
> Key: FLINK-7166
> URL: https://issues.apache.org/jira/browse/FLINK-7166
> Project: Flink
> Issue Type: Bug
> Components: Build System
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> Since the AVRO upgrade to 1.8.2, I could compile the flink-avro module any
> more with a failure like this in {{mvn clean install -DskipTests -pl
> flink-connectors/flink-avro}}:
> {code}
> Compilation failure
> [ERROR]
> flink-connectors/flink-avro/src/test/java/org/apache/flink/api/io/avro/generated/Fixed16.java:[10,8]
> org.apache.flink.api.io.avro.generated.Fixed16 is not abstract and does not
> override abstract method readExternal(java.io.ObjectInput) in
> org.apache.avro.specific.SpecificFixed
> {code}
> This was caused by maven both not cleaning up the generated sources and also
> not overwriting them with new ones itself. Only a manual {{rm -rf
> flink-connectors/flink-avro/src/test/java/org/apache/flink/api/io/avro/generated}}
> solved the issue.
> The cause for this, though, is that the avro files are generated under the
> {{src}} directory, not {{target/generated-test-sources}} as they should be.
> Either the generated sources should be cleaned up as well, or the generated
> files should be moved to this directory which is a more invasive change due
> to some hacks with respect to these files.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
