Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3614#discussion_r130315352
--- Diff:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnClusterDescriptorTest.java
---
@@ -51,57 +51,23 @@ public void beforeTest() throws IOException {
}
@Test
- public void testFailIfTaskSlotsHigherThanMaxVcores() {
-
- YarnClusterDescriptor clusterDescriptor = new
YarnClusterDescriptor();
-
- clusterDescriptor.setLocalJarPath(new Path(flinkJar.getPath()));
- clusterDescriptor.setFlinkConfiguration(new Configuration());
-
clusterDescriptor.setConfigurationDirectory(temporaryFolder.getRoot().getAbsolutePath());
- clusterDescriptor.setConfigurationFilePath(new
Path(flinkConf.getPath()));
-
- // configure slots too high
- clusterDescriptor.setTaskManagerSlots(Integer.MAX_VALUE);
-
- try {
- clusterDescriptor.deploy();
-
- fail("The deploy call should have failed.");
- } catch (RuntimeException e) {
- // we expect the cause to be an
IllegalConfigurationException
- if (!(e.getCause() instanceof
IllegalConfigurationException)) {
- throw e;
- }
- }
- }
-
- @Test
public void testConfigOverwrite() {
YarnClusterDescriptor clusterDescriptor = new
YarnClusterDescriptor();
Configuration configuration = new Configuration();
- // overwrite vcores in config
+ // configure slots in config
--- End diff --
The comment does not match the following statement
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
