[
https://issues.apache.org/jira/browse/FLINK-7320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107760#comment-16107760
]
ASF GitHub Bot commented on FLINK-7320:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4435#discussion_r130428135
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/Scheduler.java
---
@@ -152,12 +150,14 @@ else if (ret instanceof Future) {
}
}
catch (NoResourceAvailableException e) {
- return FlinkCompletableFuture.completedExceptionally(e);
+ CompletableFuture<SimpleSlot> notEnoughResources = new
CompletableFuture<>();
--- End diff --
How about introducing a utility method to create an exceptionally completed
`CompletableFuture` in one line?
> Remove Flink's futures from Scheduler
> -------------------------------------
>
> Key: FLINK-7320
> URL: https://issues.apache.org/jira/browse/FLINK-7320
> Project: Flink
> Issue Type: Sub-task
> Components: Scheduler
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
> Fix For: 1.4.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
