Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r130458506
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -179,13 +214,19 @@ class AggregationCodeGenerator(
| ${aggMapping(i)},
| (${accTypes(i)}) accs.getField($i));""".stripMargin
} else {
+ val setDataView = if (accConfig.isDefined &&
accConfig.get.isUseState) {
--- End diff --
This will create new `MapState` (or `ListState`) objects in every
invocation of `setAggregationResults()`. I think we can make the state objects
members of the `GeneratedAggregations` class and just set them into the
accumulator.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
