[
https://issues.apache.org/jira/browse/FLINK-7331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108571#comment-16108571
]
ASF GitHub Bot commented on FLINK-7331:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4444#discussion_r130549382
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -401,74 +354,37 @@ public RegistrationResponse
apply(RegistrationResponse registrationResponse, Thr
* @return The response by the ResourceManager.
*/
@RpcMethod
- public Future<RegistrationResponse> registerTaskExecutor(
--- End diff --
Unintended renaming? This method is annotated with `@RcpMethod`, we need to
change `ResourceManagerGateway` as well. Although this begs the question why we
expose an _internal_ method in the first place.
> Remove Flink's futures from ResourceManager
> -------------------------------------------
>
> Key: FLINK-7331
> URL: https://issues.apache.org/jira/browse/FLINK-7331
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
> Fix For: 1.4.0
>
>
> Remove only internally used Flink {{Futures}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
