GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/4459
[FLINK-7221] [jdbc] Throw exception if execution of last JDBC batch fails.
## What is the purpose of the change
Ensure that that an exception is thrown if the execution of the last JDBC
batch fails.
At the moment, only an INFO log is emitted which does not inform the user
that data was lost.
## Brief change log
* Throw exception in `JDBCOutputFormat.close()` if execution of last JDBC
fails.
* Split try-catch block in `JDBCOutputFormat.writeRecord()` into statement
generation and batch execution.
* Exception are changed from `IllegalArgumentException` to more generic
`RuntimeException` because they are not caused by illegal arguments.
* Add and fix test cases.
## Verifying this change
* The fix is verify by `JDBCOutputFormatTest.testExceptionOnClose()`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **yes**
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhueske/flink jdbcCloseError
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4459.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4459
----
commit b32cd13fa61cc03b83b117f2be79d93cac0ad1ba
Author: Fabian Hueske <[email protected]>
Date: 2017-08-01T16:08:53Z
[FLINK-7221] [jdbc] Throw exception if execution of last JDBC batch fails.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
