[
https://issues.apache.org/jira/browse/FLINK-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110814#comment-16110814
]
ASF GitHub Bot commented on FLINK-7334:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4462
[FLINK-7334] [futures] Replace Flink's futures with Java 8's
CompletableFuture in RpcEndpoint, RpcGateways and RpcService
## What is the purpose of the change
Replace Flink's futures with Java 8's CompletableFuture in RpcEndpoint,
RpcGateways and RpcService. Moreover, it removes the remaining usage of Flink
futures in tests.
## Brief change log
- Change RpcCompletenessTest to only accept `CompletableFutures` as return
type
- Change signature of `RpcGateways`
- Adapt all `RpcEndpoint` implementations
- Remove Flink Future usage from remaining tests
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
## Documentation
- Does this pull request introduce a new feature? (no)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink rfRpcGateway
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4462.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4462
----
commit 0e497367d8666a580d033848977b0639b037e554
Author: Till Rohrmann <[email protected]>
Date: 2017-08-01T09:33:48Z
[FLINK-7334] [futures] Replace Flink's futures with Java 8's
CompletableFuture in RpcEndpoint, RpcGateways and RpcService
Remove Futures from RpcGateways
Remove Future usage
----
> Replace Flink's futures by CompletableFuture in RpcGateway
> ----------------------------------------------------------
>
> Key: FLINK-7334
> URL: https://issues.apache.org/jira/browse/FLINK-7334
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Fix For: 1.4.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
