GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/4464

    [FLINK-7354][tests] ignore "initialSeedUniquifierGenerator" thread in 
thread list

    ## What is the purpose of the change
    
    Netty may spawn a thread in its `ThreadLocalRandom` because of some secure 
random use which may be caught in our `LocalFlinkMiniClusterITCase` thread 
check as being started but not stopped by us. We can simply ignore this thread 
and solve the test instability.
    
    Alternatively, we could solve this similarly to 
https://issues.apache.org/jira/browse/SOLR-10098 by setting 
`ThreadLocalRandom.setInitialSeedUniquifier(1L);` but that may be less future 
proof or even remove some randomness.
    
    ## Brief change log
    
      - ignore any spawned thread with prefix `"initialSeedUniquifierGenerator"`
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-7354

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4464.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4464
    
----
commit 4a26f37bbffa70e848bc0fdd80b91d5c601b4ce6
Author: Nico Kruber <n...@data-artisans.com>
Date:   2017-08-02T14:20:02Z

    [FLINK-7354][tests] ignore "initialSeedUniquifierGenerator" thread in 
thread list
    
    Netty may spawn a thread in its ThreadLocalRandom class because of some 
secure
    random use which may be caught in our LocalFlinkMiniClusterITCase as not 
being
    stopped. Let's tolerate this.
    
    Alternatively, we could solve this similarly to
    https://issues.apache.org/jira/browse/SOLR-10098 by setting
    ThreadLocalRandom.setInitialSeedUniquifier(1L);
    but that may be less future proof or even remove some randomness.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to