[ 
https://issues.apache.org/jira/browse/FLINK-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111475#comment-16111475
 ] 

ASF GitHub Bot commented on FLINK-7350:
---------------------------------------

Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4461#discussion_r130957157
  
    --- Diff: tools/travis_mvn_watchdog.sh ---
    @@ -145,8 +150,11 @@ esac
     # -nsu option forbids downloading snapshot artifacts. The only snapshot 
artifacts we depend are from
     # Flink, which however should all be built locally. see FLINK-7230
     MVN_LOGGING_OPTIONS="-Dlog.dir=${ARTIFACTS_DIR} 
-Dlog4j.configuration=file://$LOG4J_PROPERTIES 
-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn"
    -MVN_COMPILE="mvn -nsu -Dflink.forkCount=2 -Dflink.forkCountTestPackage=2 
-DskipTests -Dmaven.javadoc.skip=true -B $PROFILE $MVN_LOGGING_OPTIONS 
$MVN_COMPILE_MODULES clean install"
    -MVN_TEST="mvn -nsu -Dflink.forkCount=2 -Dflink.forkCountTestPackage=2 
-Dmaven.javadoc.skip=true -B $PROFILE $MVN_LOGGING_OPTIONS $MVN_TEST_MODULES 
verify"
    +MVN_COMMON_OPTIONS="-nsu -Dflink.forkCount=2 
-Dflink.forkCountTestPackage=2 -Dmaven.javadoc.skip=true -B 
$MVN_LOGGING_OPTIONS"
    +MVN_COMPILE_OPTIONS="$MVN_COMPILE_OPTIONS -DskipTests"
    +
    +MVN_COMPILE="mvn $MVN_COMMON_OPTIONS $MVN_COMPILE_OPTIONS $PROFILE 
$MVN_COMPILE_MODULES clean install"
    +MVN_TEST="mvn -$MVN_COMMON_OPTIONS $PROFILE $MVN_TEST_MODULES verify"
    --- End diff --
    
    Looks to be a spurious `-` after `mvn`.


> only execute japicmp in one build profile
> -----------------------------------------
>
>                 Key: FLINK-7350
>                 URL: https://issues.apache.org/jira/browse/FLINK-7350
>             Project: Flink
>          Issue Type: Improvement
>          Components: Travis
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.4.0
>
>
> Similarly to FLINK-7349 we improve build times (and stability!) by only 
> executing the japicmp plugin in the build profile that builds the all of 
> flink.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to