[
https://issues.apache.org/jira/browse/FLINK-6493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113827#comment-16113827
]
ASF GitHub Bot commented on FLINK-6493:
---------------------------------------
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4328
Thanks for that @zhangminglei. However, I've already finished testing a
batch of commits with this fix included, and would like to merge that now.
Sometimes I collect a batch of commits and run them on Travis before merging
(that's why it isn't actually merged yet).
It's safe to leave some final minor cosmetic fix to the person merging the
PR if they mentioned they'll fix it when merging. That'll also avoid duplicate
work and wasted efforts.
> Ineffective null check in RegisteredOperatorBackendStateMetaInfo#equals()
> -------------------------------------------------------------------------
>
> Key: FLINK-6493
> URL: https://issues.apache.org/jira/browse/FLINK-6493
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Reporter: Ted Yu
> Assignee: mingleizhang
> Priority: Minor
> Fix For: 1.4.0
>
>
> {code}
> && ((partitionStateSerializer == null && ((Snapshot)
> obj).getPartitionStateSerializer() == null)
> || partitionStateSerializer.equals(((Snapshot)
> obj).getPartitionStateSerializer()))
> && ((partitionStateSerializerConfigSnapshot == null && ((Snapshot)
> obj).getPartitionStateSerializerConfigSnapshot() == null)
> || partitionStateSerializerConfigSnapshot.equals(((Snapshot)
> obj).getPartitionStateSerializerConfigSnapshot()));
> {code}
> The null check for partitionStateSerializer /
> partitionStateSerializerConfigSnapshot is in combination with another clause.
> This may lead to NPE in the partitionStateSerializer.equals() call.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
