[
https://issues.apache.org/jira/browse/FLINK-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114138#comment-16114138
]
ASF GitHub Bot commented on FLINK-7307:
---------------------------------------
GitHub user zjureel opened a pull request:
https://github.com/apache/flink/pull/4476
[FLINK-7307] Add proper command line parsing tool to ClusterEntrypoint
## What is the purpose of the change
Add a proper command line parsing tool `CommandLineParser` to the entry
point of the `ClusterEntrypoint#parseArguments`
## Brief change log
- *Add command line parsing tool `CommandLineParser`*
- *Use `CommandLineParser` instead of `ParameterTool` in
`ClusterEntrypoint#parseArguments`*
## Verifying this change
*(Please pick either of the following options)*
This change added tests and can be verified as follows:
*(example:)*
- *Added test case `CommandLineParserTest`*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs /
JavaDocs / not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjureel/flink FLINK-7307
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4476.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4476
----
commit 9074a186b7961e7218a053ed211876317514a6ee
Author: zjureel <[email protected]>
Date: 2017-08-04T08:49:35Z
[FLINK-7307][improvement] Add proper command line parsing tool to
ClusterEntrypoint
----
> Add proper command line parsing tool to ClusterEntrypoint
> ---------------------------------------------------------
>
> Key: FLINK-7307
> URL: https://issues.apache.org/jira/browse/FLINK-7307
> Project: Flink
> Issue Type: Improvement
> Components: Cluster Management
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Fang Yong
> Labels: flip-6
>
> We need to add a proper command line parsing tool to the entry point of the
> {{ClusterEntrypoint#parseArguments}}. At the moment, we are simply using the
> {{ParameterTool}} as a temporary solution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)