[
https://issues.apache.org/jira/browse/FLINK-7053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114445#comment-16114445
]
ASF GitHub Bot commented on FLINK-7053:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4234#discussion_r131401420
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSslTest.java
---
@@ -107,195 +96,89 @@ public static void stopServers() throws IOException {
if (BLOB_SSL_SERVER != null) {
BLOB_SSL_SERVER.close();
}
--- End diff --
What about shutting the non ssl blob server down?
> improve code quality in some tests
> ----------------------------------
>
> Key: FLINK-7053
> URL: https://issues.apache.org/jira/browse/FLINK-7053
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, Network
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> * {{BlobClientTest}} and {{BlobClientSslTest}} share a lot of common code
> * the received buffers there are currently not verified for being equal to
> the expected one
> * {{TemporaryFolder}} should be used throughout blob store tests
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
