ASF GitHub Bot commented on FLINK-7147:

Github user dawidwys commented on a diff in the pull request:

    --- Diff: 
    @@ -637,9 +675,23 @@ private boolean isPatternOptional(Pattern<T, ?> 
pattern) {
    -                   final IterativeCondition<T> proceedCondition = 
    +                   IterativeCondition<T> proceedCondition = 
                        final State<T> loopingState = 
createState(currentPattern.getName(), State.StateType.Normal);
    -                   loopingState.addProceed(sinkState, proceedCondition);
    +                   if 
    +                           State<T> sinkStateCopy = copy(sinkState);
    --- End diff --
    If I understood correctly the copies are needed only in casese where there 
is the `untilCondition`. Am I right? If so let's create the copy then. Right 
know there are dangling copies of the next when there is no `untilCondtion`.

> Support greedy quantifier in CEP
> --------------------------------
>                 Key: FLINK-7147
>                 URL: https://issues.apache.org/jira/browse/FLINK-7147
>             Project: Flink
>          Issue Type: Sub-task
>          Components: CEP, Table API & SQL
>            Reporter: Dian Fu
>            Assignee: Dian Fu
> Greedy quantifier will try to match the token as many times as possible. For 
> example, for pattern {{a b* c}} (skip till next is used) and inputs {{a b1 b2 
> c}}, if the quantifier for {{b}} is greedy, it will only output {{a b1 b2 c}}.

This message was sent by Atlassian JIRA

Reply via email to