Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/796#discussion_r31910178
  
    --- Diff: flink-dist/src/main/flink-bin/bin/config.sh ---
    @@ -220,7 +220,7 @@ 
INTERNAL_HADOOP_CLASSPATHS="$HADOOP_CLASSPATH:$HADOOP_CONF_DIR:$YARN_CONF_DIR"
     # also potentialy includes topology information and the taskManager type
     extractHostName() {
         # extract first part of string (before any whitespace characters)
    -    SLAVE=$1
    +    SLAVE=`echo $1 | cut -d'#' -f 1`
         # Remove types and possible comments
         if [[ "$SLAVE" =~ ^([0-9a-zA-Z/.-]+).*$ ]]; then
                 SLAVE=${BASH_REMATCH[1]}
    --- End diff --
    
    No need to change line 223 because
    ```bash
    if [[ "$SLAVE" =~ ^([0-9a-zA-Z/.-]+).*$ ]]; then
                 SLAVE=${BASH_REMATCH[1]}
    fi
    ``` 
    will already filter out lines starting with `#`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to