[
https://issues.apache.org/jira/browse/FLINK-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117016#comment-16117016
]
ASF GitHub Bot commented on FLINK-6982:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4495
[FLINK-6982] [guava] Introduce flink-shaded-guava-18
## What is the purpose of the change
This PR integrates the shaded guava dependency from flink-shaded.
Basically, replace all usages of guava with the shaded guava dependency and
remove all traces of the original dependency.
Note that flink-table and flink-cassandra were excluded; both modules pull
in guava dependencies from other dependencies (calcite/cassandra) and do their
own shading.
## Brief change log
- replace all guava dependencies with flink-shaded-guava
- replace all guava imports
- add check in travis watchdog that no unshaded guava classes are present
in flink-dist
## Verifying this change
- check that compilation works
- check artifacts for inclusion of shaded guava
- check artifacts for exclusion of unshaded guava
- check that we are not exposing a vanilla guava dependency with maven
- start a cluster and run some examples
- check that the web interface still works
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6982
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4495.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4495
----
commit b4432993e2d70e1aa7844d5897325c4d417de109
Author: zentol <[email protected]>
Date: 2017-08-01T12:58:03Z
[FLINK-6982] [guava] Integrate flink-shaded-guava-18
commit 33bca61d5e36469b8b11a65df82c77c63193ea98
Author: zentol <[email protected]>
Date: 2017-06-13T15:12:31Z
replace flink-optimizer guava dependency
commit ab27c675c69d9907276f5bd35a1caf499b1d8669
Author: zentol <[email protected]>
Date: 2017-06-13T15:12:44Z
replace runtime-web guava dependency
commit f37538027f253b1ae3eb5a21c07c81da3e9221e7
Author: zentol <[email protected]>
Date: 2017-06-13T15:13:38Z
replace flink-streaming-java guava dependency
commit 529edb4e1511cdcf0778ab6cfa89b817b2f35c64
Author: zentol <[email protected]>
Date: 2017-06-13T15:20:32Z
replace flink-runtime guava dependency
commit d11483cd3056db99c3afdf07ef8dc1701770d9ef
Author: zentol <[email protected]>
Date: 2017-06-13T15:21:00Z
replace flink-cep guava dependency
commit 8a8742e6312215abd43003796a767367bd9baeca
Author: zentol <[email protected]>
Date: 2017-06-13T15:26:32Z
shaded calcites guava dependency in flink-table
commit e5a4c75e8e1c371c92c3a65bb775bbad81d117c5
Author: zentol <[email protected]>
Date: 2017-06-14T12:02:37Z
don't include gauva in shaded jars
----
> Replace guava dependencies
> --------------------------
>
> Key: FLINK-6982
> URL: https://issues.apache.org/jira/browse/FLINK-6982
> Project: Flink
> Issue Type: Sub-task
> Components: Build System
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
