Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4488#discussion_r131708260
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -245,14 +244,18 @@ abstract class CodeGenerator(
returnType: TypeInformation[_ <: Any],
resultFieldNames: Seq[String])
: GeneratedExpression = {
- val input1AccessExprs = input1Mapping.map { idx =>
- generateInputAccess(input1, input1Term, idx)
+ val input1AccessExprs = input1Mapping.map {
--- End diff --
Please add some inline comments here and also in the ScalaDoc of
`input1Mapping` and `input2Mapping`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
