Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4496#discussion_r131845049
  
    --- Diff: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/StreamOperatorChainingTest.java
 ---
    @@ -324,4 +327,18 @@ public void invoke(String value) throws Exception {
                return mockTask;
        }
     
    +   @Test
    --- End diff --
    
    It's excellent that you added a test! I think, however, that this should go 
into a new file `StreamOperatorChainingITCase` because it is an integration 
test and not a unit test (it runs a whole Flink pipeline instead of testing an 
isolated component).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to