[
https://issues.apache.org/jira/browse/FLINK-7372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119651#comment-16119651
]
ASF GitHub Bot commented on FLINK-7372:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4483#discussion_r132140409
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/client/JobClientActorTest.java
---
@@ -388,7 +391,9 @@ else if (message instanceof RegisterJobClient) {
testFuture.tell(Acknowledge.get(),
getSelf());
}
}
- else if (message instanceof RegisterTest) {
+ else if (message instanceof RequestBlobManagerPort$) {
--- End diff --
Yes because `RequestBlobManagerPort` is a case object.
> Remove ActorGateway from JobGraph
> ---------------------------------
>
> Key: FLINK-7372
> URL: https://issues.apache.org/jira/browse/FLINK-7372
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
>
> As a preliminary step for easier Flip-6 integration we should try to decouple
> as many components from the underlying RPC abstraction as possible. One of
> these components is the {{JobGraph}} which has a dependency on
> {{ActorGateway}} via its {{JobGraph#uploadUserJars}} method.
> I propose to get rid of the {{ActorGateway}} parameter and passing instead
> the BlobServer's address as an {{InetSocketAddress}} instance.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
