Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4492#discussion_r132142466
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobManagerGateway.java
 ---
    @@ -63,4 +70,103 @@
         * @return Future containing an Acknowledge message if the submission 
succeeded
         */
        CompletableFuture<Acknowledge> submitJob(JobGraph jobGraph, 
ListeningBehaviour listeningBehaviour, Time timeout);
    +
    +   /**
    +    * Cancels the given job after taking a savepoint and returning its 
path.
    +    *
    +    * If the savepointPath is null, then the JobManager will use the 
default savepoint directory
    +    * to store the savepoint in. After the savepoint has been taken and 
the job has been canceled
    +    * successfully, the path of the savepoint is returned.
    +    *
    +    * @param jobId identifying the job to cancel
    +    * @param savepointPath Optional path for the savepoint to be stored 
under; if null, then the default path is
    +    *                      taken
    +    * @param timeout for the asynchronous operation
    +    * @return Future containing the savepoint path of the taken savepoint 
or an Exception if the operation failed
    +    */
    +   CompletableFuture<String> cancelJobWithSavepoint(JobID jobId, @Nullable 
String savepointPath, Time timeout);
    +
    +   /**
    +    * Cancels the given job.
    +    *
    +    * @param jobId identifying the job to cancel
    +    * @param timeout for the asynchronous operation
    +    * @return Future containing Acknowledge or an Exception if the 
operation failed
    +    */
    +   CompletableFuture<Acknowledge> cancelJob(JobID jobId, Time timeout);
    +
    +   /**
    +    * Stops the given job.
    +    *
    +    * @param jobId identifying the job to cancel
    +    * @param timeout for the asynchronous operation
    +    * @return Future containing Acknowledge or an Exception if the 
operation failed
    +    */
    +   CompletableFuture<Acknowledge> stopJob(JobID jobId, Time timeout);
    +
    +   /**
    +    * Requests the class loading properties for the given JobID.
    +    *
    +    * @param jobId for which the class loading properties are requested
    +    * @param timeout for this operation
    +    * @return Future containing the optional class loading properties if 
they could be retrieved from the JobManager.
    +    */
    +   CompletableFuture<Optional<JobManagerMessages.ClassloadingProps>> 
requestClassloadingProps(JobID jobId, Time timeout);
    +
    +   /**
    +    * Requests the TaksManager instance registered under the given 
instanceId from the JobManager.
    --- End diff --
    
    Thanks for catching.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to