[ 
https://issues.apache.org/jira/browse/FLINK-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119812#comment-16119812
 ] 

ASF GitHub Bot commented on FLINK-6281:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3712#discussion_r132166866
  
    --- Diff: 
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTypeUtil.java
 ---
    @@ -0,0 +1,87 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.api.java.io.jdbc;
    +
    +import org.apache.flink.api.common.typeinfo.BasicTypeInfo;
    +import org.apache.flink.api.common.typeinfo.PrimitiveArrayTypeInfo;
    +import org.apache.flink.api.common.typeinfo.TypeInformation;
    +import org.apache.flink.api.common.typeutils.CompositeType;
    +import org.apache.flink.api.java.typeutils.ObjectArrayTypeInfo;
    +
    +import java.sql.Types;
    +import java.util.Collections;
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +import static 
org.apache.flink.api.common.typeinfo.BasicTypeInfo.BIG_DEC_TYPE_INFO;
    +import static 
org.apache.flink.api.common.typeinfo.BasicTypeInfo.BIG_INT_TYPE_INFO;
    +import static 
org.apache.flink.api.common.typeinfo.BasicTypeInfo.BOOLEAN_TYPE_INFO;
    +import static 
org.apache.flink.api.common.typeinfo.BasicTypeInfo.BYTE_TYPE_INFO;
    +import static 
org.apache.flink.api.common.typeinfo.BasicTypeInfo.CHAR_TYPE_INFO;
    +import static 
org.apache.flink.api.common.typeinfo.BasicTypeInfo.DATE_TYPE_INFO;
    +import static 
org.apache.flink.api.common.typeinfo.BasicTypeInfo.DOUBLE_TYPE_INFO;
    +import static 
org.apache.flink.api.common.typeinfo.BasicTypeInfo.FLOAT_TYPE_INFO;
    +import static 
org.apache.flink.api.common.typeinfo.BasicTypeInfo.INT_TYPE_INFO;
    +import static 
org.apache.flink.api.common.typeinfo.BasicTypeInfo.LONG_TYPE_INFO;
    +import static 
org.apache.flink.api.common.typeinfo.BasicTypeInfo.SHORT_TYPE_INFO;
    +import static 
org.apache.flink.api.common.typeinfo.BasicTypeInfo.STRING_TYPE_INFO;
    +
    +class JDBCTypeUtil {
    +   private static final Map<BasicTypeInfo<?>, Integer> BASIC_TYPES;
    +
    +   static {
    +           HashMap<BasicTypeInfo<?>, Integer> m = new HashMap<>();
    +           m.put(STRING_TYPE_INFO, Types.VARCHAR);
    +           m.put(BOOLEAN_TYPE_INFO, Types.BOOLEAN);
    +           m.put(BYTE_TYPE_INFO, Types.TINYINT);
    +           m.put(SHORT_TYPE_INFO, Types.SMALLINT);
    +           m.put(INT_TYPE_INFO, Types.INTEGER);
    +           m.put(LONG_TYPE_INFO, Types.BIGINT);
    +           m.put(FLOAT_TYPE_INFO, Types.FLOAT);
    +           m.put(DOUBLE_TYPE_INFO, Types.DOUBLE);
    +           m.put(CHAR_TYPE_INFO, Types.SMALLINT);
    --- End diff --
    
    `JDBCOutputFormat` will insert a `SMALLINT` by casting to `short`. This 
cast will fail for `Character`. 
    
    Please double check the type assignment and align it with 
`JDBCOutputFormat.writeRecord()`.


> Create TableSink for JDBC
> -------------------------
>
>                 Key: FLINK-6281
>                 URL: https://issues.apache.org/jira/browse/FLINK-6281
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>
> It would be nice to integrate the table APIs with the JDBC connectors so that 
> the rows in the tables can be directly pushed into JDBC.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to