GitHub user zentol opened a pull request:

    [FLINK-7395] [metrics] Count bytesIn/Out without synchronization

    ## What is the purpose of the change
    This PR changes the numBytesIn/Out measurement to not use the synchronized 
`Buffer#getSize()` method.
    ## Brief change log
      - Add unsynchronized ´Buffer#getSizeUnsafe()`
      - replace all calls by the metric system to  `Buffer#getSize()` 
    ## Verifying this change
    This change is a trivial rework / code cleanup without any test coverage.
    ## Does this pull request potentially affect one of the following parts:
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): yes 
(technically it's per-buffer, but i guess that still counts)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
    ## Documentation
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not applicable

You can merge this pull request into a Git repository by running:

    $ git pull 7395

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4504
commit c6f566916aab4b74b6437b6a153a189c6e17e793
Author: zentol <>
Date:   2017-08-09T12:43:51Z

    [FLINK-7395] [metrics] Count bytesIn/Out without synchronization


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to