Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r132169303
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -150,6 +160,59 @@ long getWindowTime() {
}
/**
+ * Check pattern after match skip strategy.
+ */
+ private void checkPatternSkipStrategy() {
+ AfterMatchSkipStrategy afterMatchSkipStrategy =
currentPattern.getAfterMatchSkipStrategy();
+ if (afterMatchSkipStrategy.getStrategy() ==
AfterMatchSkipStrategy.SkipStrategy.SKIP_TO_FIRST ||
+ afterMatchSkipStrategy.getStrategy() ==
AfterMatchSkipStrategy.SkipStrategy.SKIP_TO_LAST) {
+ Pattern<T, ?> pattern = currentPattern;
+ while
(!pattern.getName().equals(afterMatchSkipStrategy.getPatternName())) {
+ pattern = pattern.getPrevious();
+ }
+ // pattern name match check.
+ if (pattern == null) {
--- End diff --
It is always true. If `pattern.getPrevious` is `null`. The `while` loop
will throw `NullPointerException`.
Missing test for this case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
