[ 
https://issues.apache.org/jira/browse/FLINK-7395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120091#comment-16120091
 ] 

ASF GitHub Bot commented on FLINK-7395:
---------------------------------------

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4504
  
    @twalthr noticed it and found it odd that we acquire a lock for doing 
metrics stuff, and asked me whether it is correct.
    
    Since we try to keep the overhead of metrics as low as possible not 
acquiring this look seems sensible. It also ties in to the convention of not 
acquiring locks that are necessary for the job progress.
    
    I may have been to quick with marking it as a blocker though.


> NumBytesOut metric in RecordWriter call synchronized method
> -----------------------------------------------------------
>
>                 Key: FLINK-7395
>                 URL: https://issues.apache.org/jira/browse/FLINK-7395
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics
>    Affects Versions: 1.4.0, 1.3.2
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>             Fix For: 1.4.0, 1.3.3
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to