ASF GitHub Bot commented on FLINK-7124:

GitHub user tzulitai opened a pull request:


    [FLINK-7124] [flip-6] Add test to verify rescaling JobGraphs works correctly

    ## What is the purpose of the change
    This pull request adds test to verify that rescaling `JobGraph`s to 
arbitrary valid DOPs works correctly, such that the generated `ExecutionGraph` 
of each rescale is correct.
    ## Brief change log
    - Add `ExecutionGraphRescalingTest` class.
      - Contains a test that consecutively rescales (up and down) a given 
      - Contains a test that rescales to DOP beyond max parallelism. `TODO` 
ignored for now since the test doesn't properly fail as expected.
    - `[hotfix]` refactor `ExecutionGraphConstructionTest` to share utility 
graph validation code.
    ## Verifying this change
    The changes themselves are a verification of existing features. See above.
    ## Does this pull request potentially affect one of the following parts:
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no**
      - Anything that affects deployment or recovery: **no**
    ## Documentation
      - Does this pull request introduce a new feature? *no*
      - If yes, how is the feature documented? *not applicable*

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tzulitai/flink FLINK-7124

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4510
commit ce4635f209c91241757662fda9e894557bac298b
Author: Tzu-Li (Gordon) Tai <tzuli...@apache.org>
Date:   2017-08-10T05:41:40Z

    [FLINK-7124] [flip-6] Add test to verify rescaling JobGraphs works correctly
    This commit adds two tests to verify behaviours of rescaling JobGraphs:
    1. JobGraphs can be consecutively rescaled to arbitrary valid DOPs
    2. Rescaling beyond max parallelism would fail
    The second test, however, is temporarily disabled for now since it
    doesn't properly fail.

commit d2ecca2428d1801b4e96233c83216992da13a9bb
Author: Tzu-Li (Gordon) Tai <tzuli...@apache.org>
Date:   2017-08-10T05:57:09Z

    [hotfix] Refactor graph verification code in ExecutionGraphConstructionTest
    The refactoring resuses utility methods in ExecutionGraphTestUtils to
    verify constructed ExecutionGraphs.


> Allow to rescale JobGraph on JobManager
> ---------------------------------------
>                 Key: FLINK-7124
>                 URL: https://issues.apache.org/jira/browse/FLINK-7124
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Coordination
>            Reporter: Till Rohrmann
>            Assignee: Tzu-Li (Gordon) Tai
> In order to support dynamic scaling, the {{JobManager}} has to be able to 
> change the parallelism of the submitted {{JobGraph}}. This basically entails 
> that we can change the parallelism settings on the cluster side.
> We already have the functionality that we can change the parallelism if it 
> was set to {{ExecutionConfig.PARALLELISM_AUTO_MAX}}. Therefore, I think the 
> task is mostly about making sure that things really properly work when 
> requesting a parallelism change.

This message was sent by Atlassian JIRA

Reply via email to