[jira] [Commented] (FLINK-7199) Graph simplification does not set parallelism

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121350#comment-16121350
 ] 

ASF GitHub Bot commented on FLINK-7199:
---------------------------------------

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4346#discussion_r132400879
  
    --- Diff: 
flink-libraries/flink-gelly-examples/src/test/java/org/apache/flink/graph/drivers/EdgeListITCase.java
 ---
    @@ -56,214 +56,304 @@ public void testLongDescription() throws Exception {
                        ProgramParametrizationException.class);
        }
     
    +   // CirculantGraph
    +
    +   private String[] getCirculantGraphParamters(String output) {
    +           return parameters("CirculantGraph", output, "--vertex_count", 
"42", "--range0", "13:4");
    +   }
    +
        @Test
        public void testHashWithCirculantGraph() throws Exception {
    -           expectedChecksum(
    -                   parameters("CirculantGraph", "hash", "--vertex_count", 
"42", "--range0", "13:4"),
    -                   168, 0x000000000001ae80);
    +           expectedChecksum(getCirculantGraphParamters("hash"), 168, 
0x000000000001ae80);
        }
     
        @Test
        public void testPrintWithCirculantGraph() throws Exception {
                // skip 'char' since it is not printed as a number
                Assume.assumeFalse(idType.equals("char") || 
idType.equals("nativeChar"));
     
    -           expectedOutputChecksum(
    -                   parameters("CirculantGraph", "print", "--vertex_count", 
"42", "--range0", "13:4"),
    -                   new Checksum(168, 0x0000004bdcc52cbcL));
    +           expectedOutputChecksum(getCirculantGraphParamters("print"), new 
Checksum(168, 0x0000004bdcc52cbcL));
    +   }
    +
    +   @Test
    +   public void testParallelismWithCirculantGraph() throws Exception {
    +           
TestUtils.verifyParallelism(getCirculantGraphParamters("print"));
    +   }
    +
    +   // CompleteGraph
    +
    +   private String[] getCompleteGraphParamters(String output) {
    +           return parameters("CompleteGraph", output, "--vertex_count", 
"42");
        }
     
        @Test
        public void testHashWithCompleteGraph() throws Exception {
    -           expectedChecksum(
    -                   parameters("CompleteGraph", "hash", "--vertex_count", 
"42"),
    -                   1722, 0x0000000000113ca0L);
    +           expectedChecksum(getCompleteGraphParamters("hash"), 1722, 
0x0000000000113ca0L);
        }
     
        @Test
        public void testPrintWithCompleteGraph() throws Exception {
                // skip 'char' since it is not printed as a number
                Assume.assumeFalse(idType.equals("char") || 
idType.equals("nativeChar"));
     
    -           expectedOutputChecksum(
    -                   parameters("CompleteGraph", "print", "--vertex_count", 
"42"),
    -                   new Checksum(1722, 0x0000031109a0c398L));
    +           expectedOutputChecksum(getCompleteGraphParamters("print"), new 
Checksum(1722, 0x0000031109a0c398L));
    +   }
    +
    +   @Test
    +   public void testParallelismWithCompleteGraph() throws Exception {
    +           TestUtils.verifyParallelism(getCompleteGraphParamters("print"));
    +   }
    +
    +   // CycleGraph
    +
    +   private String[] getCycleGraphParamters(String output) {
    +           return parameters("CycleGraph", output, "--vertex_count", "42");
        }
     
        @Test
        public void testHashWithCycleGraph() throws Exception {
    -           expectedChecksum(
    -                   parameters("CycleGraph", "hash", "--vertex_count", 
"42"),
    -                   84, 0x000000000000d740L);
    +           expectedChecksum(getCycleGraphParamters("hash"), 84, 
0x000000000000d740L);
        }
     
        @Test
        public void testPrintWithCycleGraph() throws Exception {
                // skip 'char' since it is not printed as a number
                Assume.assumeFalse(idType.equals("char") || 
idType.equals("nativeChar"));
     
    -           expectedOutputChecksum(
    -                   parameters("CycleGraph", "print", "--vertex_count", 
"42"),
    -                   new Checksum(84, 0x000000272a136fcaL));
    +           expectedOutputChecksum(getCycleGraphParamters("print"), new 
Checksum(84, 0x000000272a136fcaL));
    +   }
    +
    +   @Test
    +   public void testParallelismWithCycleGraph() throws Exception {
    +           TestUtils.verifyParallelism(getCycleGraphParamters("print"));
    +   }
    +
    +   // EchoGraph
    +
    +   private String[] getEchoGraphParamters(String output) {
    --- End diff --
    
    same here: `getEchoGraphParameters`


> Graph simplification does not set parallelism
> ---------------------------------------------
>
>                 Key: FLINK-7199
>                 URL: https://issues.apache.org/jira/browse/FLINK-7199
>             Project: Flink
>          Issue Type: Bug
>          Components: Gelly
>    Affects Versions: 1.3.1, 1.4.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Minor
>
> The {{Simplify}} parameter should accept and set the parallelism when calling 
> the {{Simplify}} algorithms.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)