[
https://issues.apache.org/jira/browse/FLINK-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121475#comment-16121475
]
ASF GitHub Bot commented on FLINK-7408:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4512#discussion_r132426478
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
@@ -214,7 +214,7 @@ public WebRuntimeMonitor(
ExecutionContextExecutor context =
ExecutionContext$.MODULE$.fromExecutor(executorService);
// Config to enable https access to the web-ui
- boolean enableSSL =
config.getBoolean(JobManagerOptions.WEB_SSL_ENABLED) &&
SSLUtils.getSSLEnabled(config);
+ boolean enableSSL = config.getBoolean(WebOptions.SSL_ENABLED)
&& SSLUtils.getSSLEnabled(config);
--- End diff --
whitespace after `&&` seems off.
> Extract WebRuntimeMonitor options from JobManagerOptions
> --------------------------------------------------------
>
> Key: FLINK-7408
> URL: https://issues.apache.org/jira/browse/FLINK-7408
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Trivial
>
> With the Flip-6 code changes, the {{WebRuntimeMonitor}} won't run exclusively
> next to the {{JobManager}}. Therefore, it makes sense to refactor the web
> monitor options and moving them from {{JobManagerOptions}} to {{WebOptions}}
> and removing the prefix {{jobmanager}}.
> This is done as requested by
> https://github.com/apache/flink/pull/4492#issuecomment-321271819.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
