Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4511#discussion_r132439899
--- Diff: flink-dist/src/main/flink-bin/bin/config.sh ---
@@ -336,16 +336,18 @@ if [ -z "${JVM_ARGS}" ]; then
JVM_ARGS=""
fi
-# Check if deprecated HADOOP_HOME is set.
-if [ -n "$HADOOP_HOME" ]; then
- # HADOOP_HOME is set. Check if its a Hadoop 1.x or 2.x HADOOP_HOME path
- if [ -d "$HADOOP_HOME/conf" ]; then
- # its a Hadoop 1.x
- HADOOP_CONF_DIR="$HADOOP_CONF_DIR:$HADOOP_HOME/conf"
- fi
- if [ -d "$HADOOP_HOME/etc/hadoop" ]; then
- # Its Hadoop 2.2+
- HADOOP_CONF_DIR="$HADOOP_CONF_DIR:$HADOOP_HOME/etc/hadoop"
+# Check if deprecated HADOOP_HOME is set, and specify config path to
HADOOP_CONF_DIR if it's empty.
+if [ -z "$HADOOP_CONF_DIR" ]; then
+ if [ -n "$HADOOP_HOME" ]; then
+ # HADOOP_HOME is set. Check if its a Hadoop 1.x or 2.x HADOOP_HOME
path
+ if [ -d "$HADOOP_HOME/conf" ]; then
+ # its a Hadoop 1.x
+ HADOOP_CONF_DIR="$HADOOP_CONF_DIR:$HADOOP_HOME/conf"
--- End diff --
This is still putting multiple colon-separated directories in
`HADOOP_CONF_DIR`. Simply removing `$HADOOP_CONF_DIR:` here should work. Same
below.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
