Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4346#discussion_r132452312
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/drivers/parameter/LongParameter.java
---
@@ -52,16 +52,6 @@ public LongParameter(ParameterizedBase owner, String
name) {
public LongParameter setDefaultValue(long defaultValue) {
super.setDefaultValue(defaultValue);
- if (hasMinimumValue) {
- Util.checkParameter(defaultValue >= minimumValue,
- "Default value (" + defaultValue + ") must be
greater than or equal to minimum (" + minimumValue + ")");
- }
-
- if (hasMaximumValue) {
- Util.checkParameter(defaultValue <= maximumValue,
- "Default value (" + defaultValue + ") must be
less than or equal to maximum (" + maximumValue + ")");
- }
-
--- End diff --
ok, should we make this explicit in the `LongParamater` class' javadoc? For
example:
```
/**
* A {@link Parameter} storing a {@link Long} within <tt>min</tt> and
<tt>max</tt> bounds (inclusive).
*
* <p>Note that the default value may be outside of these bounds.
*/
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
