[ https://issues.apache.org/jira/browse/FLINK-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121609#comment-16121609 ]
ASF GitHub Bot commented on FLINK-7199: --------------------------------------- Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4346#discussion_r132452312 --- Diff: flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/drivers/parameter/LongParameter.java --- @@ -52,16 +52,6 @@ public LongParameter(ParameterizedBase owner, String name) { public LongParameter setDefaultValue(long defaultValue) { super.setDefaultValue(defaultValue); - if (hasMinimumValue) { - Util.checkParameter(defaultValue >= minimumValue, - "Default value (" + defaultValue + ") must be greater than or equal to minimum (" + minimumValue + ")"); - } - - if (hasMaximumValue) { - Util.checkParameter(defaultValue <= maximumValue, - "Default value (" + defaultValue + ") must be less than or equal to maximum (" + maximumValue + ")"); - } - --- End diff -- ok, should we make this explicit in the `LongParamater` class' javadoc? For example: ``` /** * A {@link Parameter} storing a {@link Long} within <tt>min</tt> and <tt>max</tt> bounds (inclusive). * * <p>Note that the default value may be outside of these bounds. */ ``` > Graph simplification does not set parallelism > --------------------------------------------- > > Key: FLINK-7199 > URL: https://issues.apache.org/jira/browse/FLINK-7199 > Project: Flink > Issue Type: Bug > Components: Gelly > Affects Versions: 1.3.1, 1.4.0 > Reporter: Greg Hogan > Assignee: Greg Hogan > Priority: Minor > > The {{Simplify}} parameter should accept and set the parallelism when calling > the {{Simplify}} algorithms. -- This message was sent by Atlassian JIRA (v6.4.14#64029)