[ 
https://issues.apache.org/jira/browse/FLINK-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121727#comment-16121727
 ] 

ASF GitHub Bot commented on FLINK-6094:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4471#discussion_r132306893
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/plan/UpdatingPlanCheckerTest.scala
 ---
    @@ -0,0 +1,203 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.plan
    +
    +import org.apache.flink.table.api.Table
    +import org.apache.flink.table.plan.util.UpdatingPlanChecker
    +import org.apache.flink.table.utils.StreamTableTestUtil
    +import org.junit.Assert._
    +import org.apache.flink.table.api.scala._
    +import org.apache.flink.api.scala._
    +import org.junit.Test
    +
    +
    +class UpdatingPlanCheckerTest {
    +
    +  @Test
    +  def testSelect(): Unit = {
    +    val util = new UpdatePlanChecnkerUtil()
    +    val table = util.addTable[(String, Int)]('word, 'number)
    +    val resultTable = table.select('word, 'number)
    +
    +    util.verifyTableUniqueKey(resultTable, Nil)
    +  }
    +
    +  @Test
    +  def testGroupByWithoutKey(): Unit = {
    +    val util = new UpdatePlanChecnkerUtil()
    +    val table = util.addTable[(String, Int)]('word, 'number)
    +
    +    val resultTable = table
    +      .groupBy('word)
    +      .select('number.count)
    +
    +    util.verifyTableUniqueKey(resultTable, Nil)
    +  }
    +
    +  @Test
    +  def testGroupBy(): Unit = {
    +    val util = new UpdatePlanChecnkerUtil()
    +    val table = util.addTable[(String, Int)]('word, 'number)
    +
    +    val resultTable = table
    +      .groupBy('word)
    +      .select('word, 'number.count)
    +
    +    util.verifyTableUniqueKey(resultTable, Seq("word"))
    +  }
    +
    +  @Test
    +  def testGroupByWithDumplicateKey(): Unit = {
    +    val util = new UpdatePlanChecnkerUtil()
    +    val table = util.addTable[(String, Int)]('word, 'number)
    +
    +    val resultTable = table
    +      .groupBy('word)
    +      .select('word as 'word1, 'word as 'word2, 'number.count)
    +
    +    util.verifyTableUniqueKey(resultTable, Seq("word1", "word2"))
    +  }
    +
    --- End diff --
    
    Please add some tests for window aggregations.


> Implement stream-stream proctime non-window  inner join
> -------------------------------------------------------
>
>                 Key: FLINK-6094
>                 URL: https://issues.apache.org/jira/browse/FLINK-6094
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Shaoxuan Wang
>            Assignee: Hequn Cheng
>
> This includes:
> 1.Implement stream-stream proctime non-window  inner join
> 2.Implement the retract process logic for join



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to