[ https://issues.apache.org/jira/browse/FLINK-7411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121812#comment-16121812 ]
ASF GitHub Bot commented on FLINK-7411: --------------------------------------- GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4517 [FLINK-7411][network] minor performance improvements in NettyMessage ## What is the purpose of the change This PR adds some (minor) performance improvements to `NettyMessage` which I came across: using a `switch` rather than multiple `if...ifelse...ifelse...` avoiding unneeded virtual method calls. ## Brief change log - use a switch rather than multiple if conditions - use static `readFrom` methods to create instances of the message sub types ## Verifying this change This change is already covered by existing tests, such as `NettyMessageSerializationTest`. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (yes) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes, if you consider network communication part of this) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) You can merge this pull request into a Git repository by running: $ git pull https://github.com/NicoK/flink flink-7411 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4517.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4517 ---- commit b33e036b43d00ddf564f105280894f6287dd3e92 Author: Nico Kruber <n...@data-artisans.com> Date: 2017-08-07T15:38:36Z [FLINK-7411][network] minor (performance) improvements in NettyMessage * use a switch rather than multiple if conditions * use static `readFrom` methods to create instances of the message sub types ---- > minor performance improvements in NettyMessage > ---------------------------------------------- > > Key: FLINK-7411 > URL: https://issues.apache.org/jira/browse/FLINK-7411 > Project: Flink > Issue Type: Improvement > Components: Network > Affects Versions: 1.4.0 > Reporter: Nico Kruber > Assignee: Nico Kruber > Priority: Minor > > {{NettyMessage}} may be improved slightly performance-wise in these regards: > - in {{NettyMessage.NettyMessageDecoder#decode()}}: instead of having > multiple if-elseif-... use a switch to cycle through the message ID > - use a static {{NettyMessage}} subtype {{readFrom(ByteBuf buffer)}} - we do > not really need to have a virtual function here -- This message was sent by Atlassian JIRA (v6.4.14#64029)