GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4527
[FLINK-7409] [web] Make WebRuntimeMonitor reactive
## What is the purpose of the change
This commit changes the behaviour of the WebRuntimeMonitor to not longer
block serving
threads by waiting on the result of futures. Instead the RequestHandler now
returns a
CompletableFuture<FullHttpResponse> which is written out to the Netty
channel upon
completion. This will improve the performance of our WebRuntimeMonitor.
This PR is based #4492.
## Brief change log
- Change signature of `RequestHandler#handleRequest`
- Adapt existing handlers to return async result
- Adapt test cases
## Verifying this change
This change is already covered by existing tests, such as the tests
contained in `flink-runtime-web`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink reactiveMonitor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4527.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4527
----
commit 734087f37c7cdf2129e87dda5f43dc4dd0c257ba
Author: Till Rohrmann <trohrm...@apache.org>
Date: 2017-08-02T16:43:00Z
[FLINK-7381] [web] Decouple WebRuntimeMonitor from ActorGateway
This PR decouples the WebRuntimeMonitor from the ActorGateway by introducing
the JobManagerGateway interface which can have multiple implementations.
This
is a preliminary step for the integration of the existing WebRuntimeMonitor
with the Flip-6 JobMaster.
Add time unit for web.timeout
This closes #4492.
commit e9ea806b09d2f1396de9bd926cced44bd0000011
Author: Till Rohrmann <trohrm...@apache.org>
Date: 2017-08-10T08:56:12Z
[FLINK-7409] [web] Make WebRuntimeMonitor reactive
This commit changes the behaviour of the WebRuntimeMonitor to not longer
block serving
threads by waiting on the result of futures. Instead the RequestHandler now
returns a
CompletableFuture<FullHttpResponse> which is written out to the Netty
channel upon
completion. This will improve the performance of our WebRuntimeMonitor.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
