Nico Kruber created FLINK-7428:

             Summary: avoid one additional buffer copy when receiving messages
                 Key: FLINK-7428
             Project: Flink
          Issue Type: Improvement
          Components: Network
    Affects Versions: 1.4.0
            Reporter: Nico Kruber
            Assignee: Nico Kruber

By using {{LengthFieldBasedFrameDecoder}}, we create one unnecessary (netty) 
buffer copy in this class which could be easily avoided since we can ensure 
that the buffer is free to be released after decoding it in the 
{{NettyMessageDecoder}} and into our own buffer and/or events.

The solution would be to make {{NettyMessageDecoder}} extend from 
{{LengthFieldBasedFrameDecoder}} and handle the decoding of the frames and the 
objects in there. In the frame creation otherwise done by 
{{LengthFieldBasedFrameDecoder}}, we could use a sliced buffer instead. This 
solution also makes the channel pipelines a bit simpler.

This message was sent by Atlassian JIRA

Reply via email to