Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4537#discussion_r132999950
--- Diff:
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java
---
@@ -1062,4 +1104,28 @@ public boolean isClearCalled() {
return fakeRestoredState;
}
+
+ private final class NonSerializableDeserializationSchema implements
KinesisDeserializationSchema<String> {
--- End diff --
Can you please add a comment explaining why this is not serializable and
why the following one is serializable? Basically pointing out this class is not
static.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
