Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4353#discussion_r133021720
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorTest.java
 ---
    @@ -850,18 +843,20 @@ public void 
testSuccessfulCheckpointSubsumesUnsuccessful() {
                        OperatorID opID2 = 
OperatorID.fromJobVertexID(ackVertex2.getJobvertexId());
                        OperatorID opID3 = 
OperatorID.fromJobVertexID(ackVertex3.getJobvertexId());
     
    -                   Map<OperatorID, OperatorState> operatorStates1 = 
pending1.getOperatorStates();
    +                   TaskStateSnapshot taskOperatorSubtaskStates1_1 = 
spy(new TaskStateSnapshot());
    --- End diff --
    
    Is spying necessary here? There seem to be no `verify()` calls on this 
type...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to