[
https://issues.apache.org/jira/browse/FLINK-7461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129011#comment-16129011
]
ASF GitHub Bot commented on FLINK-7461:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4550#discussion_r133493395
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/StateUtil.java ---
@@ -49,27 +49,8 @@ public static long getStateSize(StateObject handle) {
* @throws Exception exception that is a collection of all suppressed
exceptions that were caught during iteration
*/
public static void bestEffortDiscardAllStateObjects(
- Iterable<? extends StateObject> handlesToDiscard)
throws Exception {
-
- if (handlesToDiscard != null) {
- Exception exception = null;
-
- for (StateObject state : handlesToDiscard) {
-
- if (state != null) {
- try {
- state.discardState();
- }
- catch (Exception ex) {
- exception =
ExceptionUtils.firstOrSuppressed(ex, exception);
- }
- }
- }
-
- if (exception != null) {
- throw exception;
- }
- }
+ Iterable<? extends StateObject> handlesToDiscard) throws
Exception {
+
LambdaUtil.applyToAllWhileSuppressingExceptions(handlesToDiscard,
StateObject::discardState);
--- End diff --
Is this change really necessary?
> Remove Backwards compatibility for Flink 1.1 from Flink 1.4
> -----------------------------------------------------------
>
> Key: FLINK-7461
> URL: https://issues.apache.org/jira/browse/FLINK-7461
> Project: Flink
> Issue Type: Improvement
> Affects Versions: 1.4.0
> Reporter: Stefan Richter
> Assignee: Stefan Richter
>
> This issue tracks the removal of Flink 1.1 backwards compatibility from Flink
> 1.4. This step is helpful for further developments because it will remove
> many old code paths and special cases. In particular, we can drop all
> handling for non-partitionable state, i.e. state that was created with the
> old {{Checkpointed}} interface.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
