[
https://issues.apache.org/jira/browse/FLINK-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130194#comment-16130194
]
ASF GitHub Bot commented on FLINK-7056:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4558#discussion_r133674886
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientTest.java
---
@@ -139,30 +139,35 @@ private static BlobKey prepareTestFile(File file)
throws IOException {
* the specified buffer.
*
* @param inputStream
- * the input stream returned from the GET operation
+ * the input stream returned from the GET operation (will be
closed by this method)
* @param buf
* the buffer to compare the input stream's data to
* @throws IOException
* thrown if an I/O error occurs while reading the input stream
*/
static void validateGet(final InputStream inputStream, final byte[]
buf) throws IOException {
--- End diff --
`s/validateGet/validateGetAndClose/g` - to avoid surprises for the function
users :)
> add API to allow job-related BLOBs to be stored
> -----------------------------------------------
>
> Key: FLINK-7056
> URL: https://issues.apache.org/jira/browse/FLINK-7056
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, Network
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Fix For: 1.4.0
>
>
> To ease cleanup, we will make job-related BLOBs be reflected in the blob
> storage so that they may be removed along with the job. This adds the jobId
> to many methods similar to the previous code from the {{NAME_ADDRESSABLE}}
> mode.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
