[
https://issues.apache.org/jira/browse/FLINK-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131403#comment-16131403
]
ASF GitHub Bot commented on FLINK-7245:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4530#discussion_r133843436
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/operators/KeyedCoProcessOperatorWithWatermarkDelayTest.scala
---
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.table.runtime.operators
+
+import java.util.concurrent.ConcurrentLinkedQueue
+
+import org.apache.flink.api.common.typeinfo.BasicTypeInfo
+import org.apache.flink.api.java.functions.KeySelector
+import org.apache.flink.streaming.api.functions.co.CoProcessFunction
+import org.apache.flink.streaming.api.watermark.Watermark
+import
org.apache.flink.streaming.util.{KeyedTwoInputStreamOperatorTestHarness,
TestHarnessUtil}
+import org.apache.flink.util.{Collector, TestLogger}
+
+import org.junit.{Assert, Test}
+
+/**
+ * Tests {@link KeyedProcessOperatorWithWatermarkDelay}.
+ */
+class KeyedCoProcessOperatorWithWatermarkDelayTest extends TestLogger {
+
+ @Test
+ def testHoldingBackWatermarks(): Unit = {
+ val operator = new KeyedCoProcessOperatorWithWatermarkDelay[String,
Integer, String, String](
+ new EmptyCoProcessFunction, 100)
+ val testHarness = new KeyedTwoInputStreamOperatorTestHarness[String,
Integer, String, String](
+ operator, new IntToStringKeySelector, new
CoIdentityKeySelector[String],
+ BasicTypeInfo.STRING_TYPE_INFO)
+ testHarness.setup()
+ testHarness.open()
+ testHarness.processWatermark1(new Watermark(101))
+ testHarness.processWatermark2(new Watermark(202))
+ testHarness.processWatermark1(new Watermark(103))
+ testHarness.processWatermark2(new Watermark(204))
+ val expectedOutput = new ConcurrentLinkedQueue[AnyRef]
+ expectedOutput.add(new Watermark(1))
+ expectedOutput.add(new Watermark(3))
+ TestHarnessUtil.assertOutputEquals("Output was not correct.",
expectedOutput,
--- End diff --
Please format parameter lists that do not fit into one line as follows:
```
TestHarnessUtil.assertOutputEquals(
"Output was not correct.",
expectedOutput,
testHarness.getOutput)
```
> Enhance the operators to support holding back watermarks
> --------------------------------------------------------
>
> Key: FLINK-7245
> URL: https://issues.apache.org/jira/browse/FLINK-7245
> Project: Flink
> Issue Type: New Feature
> Components: DataStream API
> Reporter: Xingcan Cui
> Assignee: Xingcan Cui
>
> Currently the watermarks are applied and emitted by the
> {{AbstractStreamOperator}} instantly.
> {code:java}
> public void processWatermark(Watermark mark) throws Exception {
> if (timeServiceManager != null) {
> timeServiceManager.advanceWatermark(mark);
> }
> output.emitWatermark(mark);
> }
> {code}
> Some calculation results (with timestamp fields) triggered by these
> watermarks (e.g., join or aggregate results) may be regarded as delayed by
> the downstream operators since their timestamps must be less than or equal to
> the corresponding triggers.
> This issue aims to add another "working mode", which supports holding back
> watermarks, to current operators. These watermarks should be blocked and
> stored by the operators until all the corresponding new generated results are
> emitted.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
