[
https://issues.apache.org/jira/browse/FLINK-7269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134821#comment-16134821
]
ASF GitHub Bot commented on FLINK-7269:
---------------------------------------
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4415
@EronWright the driving rationale is that the static variable is an anti
pattern which can cause problems which are hard to track and understand. E.g.
it is really hard to find out where the values are actually set which you
retrieve at another position via the static variable. Instead, we should always
pass the respective configuration objects to the respective components.
> Refactor passing of dynamic properties
> --------------------------------------
>
> Key: FLINK-7269
> URL: https://issues.apache.org/jira/browse/FLINK-7269
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 1.3.1
> Reporter: Till Rohrmann
> Assignee: Fang Yong
> Fix For: 1.4.0
>
>
> In order to set dynamic properties when loading the {{Configuration}} via
> {{GlobalConfiguration.loadConfiguration}}, we currently set a static field in
> {{GlobalConfiguration}} which is read whenever we load the {{Configuration}}.
> I think this is not a good pattern I propose to remove this functionality.
> Instead we should explicitly add the dynamic properties to the loaded
> {{Configuration}} at start of the application.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
