Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/811#discussion_r32029536
  
    --- Diff: tools/create_release_files.sh ---
    @@ -36,57 +58,59 @@ if [[ `basename $CURR_DIR` != "tools" ]] ; then
       exit 1
     fi
     
    +##
    +## Variables with defaults (if not overwritten by environment)
    +##
     GPG_PASSPHRASE=${GPG_PASSPHRASE:-XXX}
     GPG_KEY=${GPG_KEY:-XXX}
    +GIT_AUTHOR=${GIT_AUTHOR:-"Your name <[email protected]>"}
     GIT_BRANCH=${GIT_BRANCH:-branch-1.0}
     OLD_VERSION=${OLD_VERSION:-0.6-incubating-SNAPSHOT}
     RELEASE_VERSION=${NEW_VERSION}
     RELEASE_CANDIDATE=${RELEASE_CANDIDATE:-rc1}
     NEW_VERSION_HADOOP1=${NEW_VERSION_HADOOP1:-"$RELEASE_VERSION-hadoop1"}
    -USER_NAME=${USER_NAME:-pwendell}
    +USER_NAME=${USER_NAME:-yourapacheidhere}
     MVN=${MVN:-mvn}
     GPG=${GPG:-gpg}
    -SHASUM=${SHASUM:-sha512sum}
    -MD5SUM=${MD5SUM:-md5sum}
    -sonatype_user=${sonatype_user:-rmetzger} #legacy variable name referring 
to maven
    +sonatype_user=${sonatype_user:-yourapacheidhere}
     sonatype_pw=${sonatype_pw:-XXX}
     
    -#echo $NEW_VERSION_HADOOP1
    -#sleep 5
    -#set -e
     
    -# create source package
    +if [ "$(uname)" == "Darwin" ]; then
    +    SHASUM=shasum
    +    MD5SUM=md5
    --- End diff --
    
    this has to be `md5 -r`. on my machine, md5 produces
    ```
    $md5 pom.xml 
    MD5 (pom.xml) = 7ed5618e87c804233d5e4f18ab7aa7a6
    ```
    whereas the `md5sum` behaviour is
    ```
    Adding the `-r` flag reverses the output, which produces the expected 
result.
    $ md5sum pom.xml
    4894008e9ef41fa2925e3596b07ce1d7  pom.xml
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to