Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4355
Hi @wuchong,
I think we don't need to call `open()` and `close()` in
`AggregateAggFunction`. `GeneratedAggregations` is an internal class which is
not exposed to users. It would be a bug in the translation logic if a
`GeneratedAggregations` which requires `open()` or `close()` would be passed to
a `AggregateAggFunction`. A user couldn't do anything to prevent this.
+1 for refactoring `AggregateCodeGenerator`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
