[ 
https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144448#comment-16144448
 ] 

ASF GitHub Bot commented on FLINK-7206:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4355#discussion_r135524948
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
 ---
    @@ -42,6 +46,18 @@ class AggregationCodeGenerator(
         input: TypeInformation[_ <: Any])
       extends CodeGenerator(config, nullableInput, input) {
     
    +  // set of statements for cleanup dataview that will be added only once
    +  // we use a LinkedHashSet to keep the insertion order
    +  private val reusableCleanupStatements = mutable.LinkedHashSet[String]()
    +
    +  /**
    +    * @return code block of statements that need to be placed in the 
cleanup() method of
    --- End diff --
    
    `RichFunction` does not have a `cleanup()` method. The `cleanup()` method 
is a method of `GeneratedAggregations`.


> Implementation of DataView to support state access for UDAGG
> ------------------------------------------------------------
>
>                 Key: FLINK-7206
>                 URL: https://issues.apache.org/jira/browse/FLINK-7206
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Kaibo Zhou
>            Assignee: Kaibo Zhou
>
> Implementation of MapView and ListView to support state access for UDAGG.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to