Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3829#discussion_r136104550
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
 ---
    @@ -106,6 +106,43 @@ abstract class BatchTableEnvironment(
       }
     
       /**
    +    * Registers an external [[TableSink]] in this [[TableEnvironment]]'s 
catalog.
    +    * Registered sink tables can be referenced in SQL DML clause.
    +    *
    +    * Examples:
    +    *
    +    * - predefine a table sink with schema
    --- End diff --
    
    I think we should not require users to correctly configure the field names 
and types of the table sink before registering it.
    We can configure it ourselves:
    
    ```
    val tableSink: TableSink = ...
    val fieldNames: Array[String]  = Array("a", "b", "c")
    val fieldTypes: Array[TypeInformation[_]]  = Array(Types.INT, Types.LONG, 
Types.STRING)
    
    tableEnv.registerTableSink("example_sink_table", fieldNames, fieldTypes, 
tableSink)
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to