Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r137032484
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/WindowJoinUtil.scala
---
@@ -225,7 +233,7 @@ object WindowJoinUtil {
case t: TimeIndicatorRelDataType =>
// time attribute access. Remember time type and side of input
val isLeftInput = idx < leftFieldCount
- Seq(TimeAttributeAccess(t.isEventTime, isLeftInput))
+ Seq(TimeAttributeAccess(t.isEventTime, isLeftInput, idx))
--- End diff --
I would do the subtraction here:
```
if (idx < leftFieldCount) {
Seq(TimeAttributeAccess(t.isEventTime, true, idx))
} else {
Seq(TimeAttributeAccess(t.isEventTime, false, idx - leftFieldCount))
}
```
---
