GitHub user gallenvara opened a pull request:

    https://github.com/apache/flink/pull/4649

    [FLINK-6116] Watermarks don't work when unioning with same DataStream.

    ## What is the purpose of the change
    
    In self-union case, the stream edges between the source and target will be 
regard as the single one. The `streamOutputMap` in `StreamGraph` will create 
only one `RecordWriterOutput` instance.
    
    
    ## Brief change log
    
      - Add edge subId for differentiating streamEdge between the same source 
and target node.
    
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
    `testUnion` case in `DataStreamTest`
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not documented)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gallenvara/flink flink-6116

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4649.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4649
    
----
commit 63fd621cfab75673a03b75b205cdd216267958a8
Author: gallenvara <[email protected]>
Date:   2017-09-06T08:24:39Z

    add edge subId for StreamEdge.

----


---

Reply via email to